Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 4.4.0 -> 4.5.0; radare2-cutter: 1.10.3 -> 1.11.0 #94708

Merged
merged 2 commits into from Aug 5, 2020
Merged

radare2: 4.4.0 -> 4.5.0; radare2-cutter: 1.10.3 -> 1.11.0 #94708

merged 2 commits into from Aug 5, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 5, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from dtzWill, 7c6f434c and makefu August 5, 2020 09:04
lsix
lsix approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and compiled (with nix-review) and tested locally.

Seems all good to me.

@Mic92 Mic92 merged commit 460c2c4 into NixOS:master Aug 5, 2020
@Mic92 Mic92 deleted the radare2 branch August 5, 2020 21:16
@Mic92 Mic92 mentioned this pull request Aug 5, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @lsix