Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice-still: use icu64 #94712

Merged
merged 1 commit into from Aug 5, 2020
Merged

libreoffice-still: use icu64 #94712

merged 1 commit into from Aug 5, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Aug 5, 2020

Motivation for this change

The libreoffice build is currently failing on master. Bisecting revealed #93482 as the cause.

hydra nixpkgs:trunk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Aug 5, 2020

Result of nixpkgs-review pr 94712 1

4 packages built:
- libreoffice (libreoffice-still)
- libreoffice-unwrapped (libreoffice-still-unwrapped)
- odpdown
- unoconv

@flokli flokli merged commit 0aebcb9 into NixOS:master Aug 5, 2020
@flokli
Copy link
Contributor

flokli commented Aug 5, 2020

Built locally. Thanks!

@B4dM4n B4dM4n deleted the libreoffice-still-icu branch August 5, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @flokli