python3Packages.pytorch: fix Darwin build by disabling GCD #94750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
|
@GrahamcOfBorg build python37Packages.pytorch |
PyTorch 1.6.0 has updated the vendored pthreadpool library, which has recently added support for Grand Central Dispatch. Unfortunately, it uses functionality (DISPATCH_APPLY_AUTO) that is only available since macOS 10.13, whereas we are still using 10.12 libraries. We can't directly pass through option to vendored libraries, since the setup.py scripts creates/filters the options that are passed to CMake. So, instead, this adds a small patch that disables the GCD functionality in pthreadpool.
danieldk
force-pushed
the
pytorch-darwin-fix
branch
2 times, most recently
from
02fca59
to
fddf279
Compare
|
Thanks @jonringer ! Turns out pthreadpool attempts to use GCD anyway in a header, even if it's configured not to in CMake. So, I have updated the patch to fix this. I also found that Hopefully it will build now. It would be nice if someone with Darwin privileges could trigger the build again. |
The library name fixup was attempted on the dev output, whereas it should be applied to the lib output.
danieldk
force-pushed
the
pytorch-darwin-fix
branch
from
fddf279
to
95f57a3
Compare
|
Builds successfully on my MacBook now: So, this is ready for review. |
|
@GrahamcOfBorg build python37Packages.pytorch |
|
Timed out 😢. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Request: could someone with Darwin ofborg privileges trigger a build of
python37Packages.pytorchandpython38Packages.pytorch? My MacBook is not fast enough that I want to attempt a full build of PyTorch to test this.PyTorch 1.6.0 has updated the vendored pthreadpool library, which has recently
added support for Grand Central Dispatch. Unfortunately, it uses functionality
(DISPATCH_APPLY_AUTO) that is only available since macOS 10.13, whereas we are
still using 10.12 libraries.
We can't directly pass through option to vendored libraries, since the setup.py
scripts creates/filters the options that are passed to CMake. So, instead, this
adds a small patch that disables the GCD functionality in pthreadpool.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)