Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use src instead of srcs in Python packages #95469

Merged
merged 2 commits into from Aug 15, 2020
Merged

Use src instead of srcs in Python packages #95469

merged 2 commits into from Aug 15, 2020

Conversation

cript0nauta
Copy link
Contributor

Motivation for this change

This change addresses an issue mapping nixpkgs Python packages to PyPI names in pynixify: cript0nauta/pynixify#40.

From what I understand, using srcs in derivations should only be done when you need two or more different sources. In the case of jq and openwrt-luci-rpc, they only have one source so I see no reason for not using src.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Seems like a nice cleanup to me!

@ofborg ofborg bot requested review from matt-snider and benley August 15, 2020 01:11
@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Result of nixpkgs-review pr 95469 1

1 package marked as broken and skipped:
- python38Packages.optuna
5 packages built:
- python27Packages.jq
- python37Packages.jq
- python37Packages.openwrt-luci-rpc
- python38Packages.jq
- python38Packages.openwrt-luci-rpc

@bhipple bhipple merged commit b93a36c into NixOS:master Aug 15, 2020
@cript0nauta cript0nauta mentioned this pull request Aug 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matt-snider matt-snider Awaiting requested review from matt-snider

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cript0nauta @bhipple