Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smimesign: 0.0.13 -> 0.1.0 #95468

Merged
merged 1 commit into from Aug 18, 2020
Merged

smimesign: 0.0.13 -> 0.1.0 #95468

merged 1 commit into from Aug 18, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and ericnorris August 15, 2020 00:57
alyssais
alyssais previously requested changes Aug 16, 2020
View reviewed changes
pkgs/os-specific/darwin/smimesign/default.nix Outdated
description = "An S/MIME signing utility for macOS and Windows that is compatible with Git";
homepage = "https://github.com/github/smimesign";
license = licenses.mit;
platforms = platforms.darwin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = platforms.darwin;
platforms = platforms.darwin ++ platforms.windows;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our go doesn't have support for windows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.platforms is usually used to communicate the platforms intended to be supported by upstream, rather than the ones our package works on. Most packages that have platform.all probably don’t build on Windows, but they still include it to communicate that in theory the software is compatible with that platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added platforms.windows.

@zowoq zowoq dismissed alyssais’s stale review August 18, 2020 00:24

made the requested changes

@zowoq zowoq merged commit 0dc28e4 into NixOS:master Aug 18, 2020
@zowoq zowoq deleted the smimesign branch August 18, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@ericnorris ericnorris Awaiting requested review from ericnorris

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @alyssais