Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rargs: init at 0.3.0 #95509

Merged
merged 2 commits into from Aug 21, 2020
Merged

rargs: init at 0.3.0 #95509

merged 2 commits into from Aug 21, 2020

Conversation

pblkt
Copy link
Contributor

@pblkt pblkt commented Aug 15, 2020

Motivation for this change

Include rargs in NixOS

Things done

Added the rargs derivation

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/95509
1 package built:
rargs

pkgs/tools/misc/rargs/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/rargs/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more suggestion, otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/95509
1 package built:
rargs

pkgs/tools/misc/rargs/default.nix Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, adding a maintainer, and a package addition I consider two different actions.

The commit history should be:

maintainers: add pblkt
rargs: init at 0.3.0

to do this:

git reset HEAD^
git add lib
git commit -m "maintainers: add pblkt"
git add pkgs
git commit -m "rargs: init at 0.3.0"
git push ... ... --force

maintainers/maintainer-list.nix Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95509 1

1 package built:
- rargs

@jonringer jonringer merged commit a2780ce into NixOS:master Aug 21, 2020
@pblkt pblkt deleted the rargs-0.3.0 branch August 22, 2020 10:56
@totoroot
Copy link
Contributor

totoroot commented Mar 8, 2021

@pblkt I just wanted to let you know that the provided GitHub URL (https://github.com/lolabout/rargs) is incorrect. The correct GitHub user is lotabout, therefore the URL for this package should be https://github.com/lotabout/rargs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants