New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rargs: init at 0.3.0 #95509
rargs: init at 0.3.0 #95509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
https://github.com/NixOS/nixpkgs/pull/95509
1 package built:
rargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, one more suggestion, otherwise LGTM
https://github.com/NixOS/nixpkgs/pull/95509
1 package built:
rargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, adding a maintainer, and a package addition I consider two different actions.
The commit history should be:
maintainers: add pblkt
rargs: init at 0.3.0
to do this:
git reset HEAD^
git add lib
git commit -m "maintainers: add pblkt"
git add pkgs
git commit -m "rargs: init at 0.3.0"
git push ... ... --force
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pblkt I just wanted to let you know that the provided GitHub URL (https://github.com/lolabout/rargs) is incorrect. The correct GitHub user is lotabout, therefore the URL for this package should be https://github.com/lotabout/rargs |
Motivation for this change
Include rargs in NixOS
Things done
Added the
rargs
derivationsandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)