Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openethereum, udpt: remove verifyCargoDeps #95467

Merged
merged 2 commits into from Aug 15, 2020
Merged

openethereum, udpt: remove verifyCargoDeps #95467

merged 2 commits into from Aug 15, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 15, 2020

Motivation for this change

verifyCargoDeps was removed from buildRustPackage a while ago.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested a review from mmahut as a code owner August 15, 2020 00:38
@ofborg ofborg bot requested review from makefu and akru August 15, 2020 00:56
@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Result of nixpkgs-review pr 95467 1

1 package failed to build:
- openethereum
1 package built:
- udpt

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Failure was because my builder ran out of disk space 😓

This is a no-op, since that attr no longer exists (it's the default behavior now).

@bhipple bhipple merged commit 71447d0 into NixOS:master Aug 15, 2020
@zowoq zowoq deleted the verifycargo branch August 15, 2020 01:34
@zowoq
Copy link
Contributor Author

zowoq commented Aug 20, 2020

And it's back!

nixpkgs/pkgs/development/compilers/elm/packages/elm-json.nix

Line 18 in a653b54

verifyCargoDeps = true;

Removed in d3ae8e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@makefu makefu Awaiting requested review from makefu

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @bhipple