Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.pango: Bump version (including deps) to fix build #95434

Merged
merged 1 commit into from Aug 14, 2020
Merged

[haskell-updates] haskellPackages.pango: Bump version (including deps) to fix build #95434

merged 1 commit into from Aug 14, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Aug 14, 2020 •
edited

This does not fix all haskell-gi dependencies. I have limited myself to
the ones needed to build webkitgtk, because I care about that one and
the issue is hopefully only temporary anyways.

Motivation for this change

gi-pango broke because of updates in the C libs it links against.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.pango: Bump version (including deps) to fix build
06fba20 
This does not file all haskell-gi dependencies. I have limited myself to
the ones needed to build webkitgtk, because I care about that one and
the issue is hopefully only temporary anyways.
@maralorn maralorn changed the title [haskell-updates] https://github.com/ghcjs/jsaddle/pull/119/commits [haskell-updates] haskellPackages.pango: Bump version (including deps) to fix build Aug 14, 2020
@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.pango
@GrahamcOfBorg build haskellPackages.haskell-gi
@GrahamcOfBorg build haskellPackages.haskell-gi-base
@GrahamcOfBorg build haskellPackages.reflex-dom

@maralorn
Copy link
Member Author

I stole most of this from https://gist.github.com/srhb/6145338b0ff62fa2f7f42ce839832d6d btw. so thx @srhb.
We could probably also fix taffybar, but I am a bit suspicious of those src overrides, so I didn‘t dare touching it.

@maralorn
Copy link
Member Author

nixpkgs-review reports:

2 packages failed to build:
taffybar termonad-with-packages

But they are already broken. So this PR makes things better, not worse.

@peti peti merged commit 5ab537e into NixOS:haskell-updates Aug 14, 2020
@maralorn maralorn deleted the fix-gi-pango branch August 14, 2020 19:02
@maralorn maralorn mentioned this pull request Aug 14, 2020
Closed
10 tasks
@cdepillabout
Copy link
Member

Just FYI, occasionally we add packages to the top of this list:

nixpkgs/pkgs/development/haskell-modules/configuration-hackage2nix.yaml

Lines 45 to 78 in d8e0ade

# This is a list of packages with versions from the latest Stackage LTS release.
#
# The packages and versions in this list cause the `hackage2nix` tool to
# generate the package at the given version.
#
# For instance, with a line like the following:
#
# - aeson ==1.4.6.0
#
# `hackage2nix` will generate the `aeson` package at version 1.4.6.0 in the
# ./hackage-packages.nix file.
#
# Since the packages in the LTS package set are sometimes older than the latest
# on Hackage, `hackage2nix` is smart enough to also generate the latest version
# of a given package.
#
# In the above example with aeson, if there was version 1.5.0.0 of aeson
# available on Hackage, `hackage2nix` would generate two packages, `aeson`
# at version 1.4.6.0 and `aeson_1_5_0_0` at version 1.5.0.0.
#
# WARNING: This list is generated semiautomatically based on the most recent
# LTS package set. If you want to add entries to it, you must do so before the
# comment saying "# LTS Haskell x.y". Any changes after that commend will be
# lost the next time `update-stackage.sh` runs.
default-package-overrides:
# This was only intended for ghc-7.0.4, and has very old deps, one hidden behind a flag
- MissingH ==1.4.2.0
# gi-gdkx11-4.x requires gtk-4.x, which is still under development and
# not yet available in Nixpkgs
- gi-gdkx11 < 4
# LTS Haskell 16.9
- abstract-deque ==0.3
- abstract-par ==0.3.3
- AC-Angle ==1.0

In the future, this might be slightly easier than manually overriding in configuration-common.nix.

@maralorn
Copy link
Member Author

Yeah, I thought about that. But than there were two mentions of that packages in that list, right? How would that behave? And I can‘t add asserts in the yaml. Or is there some way to mitigate that?

@cdepillabout
Copy link
Member

But than there were two mentions of that packages in that list, right? How would that behave?

Ah, good call. I didn't think about that! I'm not sure if that would work then.

This was referenced Aug 18, 2020
Merged
Merged
@cdepillabout cdepillabout mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maralorn @cdepillabout @peti