Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates]: haskellPackages.haskell-language-server: Fix evalution errors #95439

Merged
merged 1 commit into from Aug 14, 2020
Merged

[haskell-updates]: haskellPackages.haskell-language-server: Fix evalution errors #95439

merged 1 commit into from Aug 14, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Aug 14, 2020 •
edited

Motivation for this change

Fix an evalution error. hie-bios had released a new version to hackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.haskell-language-server

@peti peti merged commit 5020cf8 into NixOS:haskell-updates Aug 14, 2020
@maralorn maralorn deleted the fix-evaluation branch August 14, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @peti