Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.recommonmark: disable tests #95457

Merged
merged 1 commit into from Aug 14, 2020
Merged

python3Packages.recommonmark: disable tests #95457

merged 1 commit into from Aug 14, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 14, 2020 •
edited

Motivation for this change

upstream appears to support python3

tests fail against latest sphinx, but errors suggest
session needs to be cleaned

related: #94591

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
python3Packages.recommonmark: disable tests
81a3d78 
fails against latest sphinx, but errors suggest
session needs to be cleaned
@jonringer jonringer requested a review from FRidh as a code owner August 14, 2020 21:29
mweinelt
mweinelt approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit too heavy for nixpkgs-review, but the package builds and the import check works.

LGTM

@mweinelt mweinelt merged commit 5bb50d6 into NixOS:master Aug 14, 2020
@jonringer jonringer deleted the re-enable-recommonmark branch August 14, 2020 23:04
@jonringer
Copy link
Contributor Author 

patroni python37Packages.kubernetes python37Packages.rl-coach python38Packages.kubernetes streamlit

7 packages built:
cachix hercules-ci-agent python27Packages.recommonmark python37Packages.altair python37Packages.recommonmark python38Packages.altair python38Packages.recommonmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt