Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.gh: enable checks #95473

Merged
merged 1 commit into from Aug 15, 2020
Merged

gitAndTools.gh: enable checks #95473

merged 1 commit into from Aug 15, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mweinelt
mweinelt approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@mweinelt mweinelt merged commit ee6b6fe into NixOS:master Aug 15, 2020
@ofborg ofborg bot requested a review from kalbasit August 15, 2020 01:50
@zowoq
Copy link
Contributor Author

zowoq commented Aug 15, 2020

@mweinelt I opened a PR instead of just pushing to master as I wanted this to build on all ofborg platforms before merging.

@zowoq zowoq deleted the gh branch August 15, 2020 01:54
@mweinelt
Copy link
Member

Ah, sorry. This would've been a great motivational text.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 15, 2020

This would've been a great motivational text.

I don't understand what this means?

@mweinelt
Copy link
Member

I couldn't have guessed your intent, so writing it down probably would've helped. Thought the "Motivation for this change" section could've been a good spot.

But I grant you that I might have merged too fast. Shame on me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @mweinelt