Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: fix headless build #95429

Merged
merged 1 commit into from Aug 14, 2020
Merged

factorio: fix headless build #95429

merged 1 commit into from Aug 14, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

#94821 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 14, 2020 •
edited

@GrahamcOfBorg build factorio-demo factorio-headless

Unfree 🤷‍♂️

@ofborg ofborg bot requested review from Baughn, erictapen and elitak August 14, 2020 15:14
jonringer
jonringer approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/95429
2 packages failed to build:
factorio factorio-experimental

3 packages built:
factorio-demo factorio-headless factorio-headless-experimental

@jonringer jonringer merged commit 096a73f into NixOS:master Aug 14, 2020
@mweinelt mweinelt deleted the factorio branch August 14, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Baughn Baughn Awaiting requested review from Baughn

@erictapen erictapen Awaiting requested review from erictapen

@elitak elitak Awaiting requested review from elitak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer