vtk_9: init at 9.0.1 #95450
Merged
vtk_9: init at 9.0.1 #95450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 14, 2020
What do you think about keeping the python3Packages.vtk using VTK7? Or you think it's better to add a python3Packages.vtk_7? |
|
Other problem is that some packages depending on VTK only work with the version 8, not with the version 9. I need to update those packages. See: |
We try to only have 1 version of a package for a given interpreter. This avoid situations where a number of packages bring in many version of a given package. But at runtime, python will import only one. So some packages will be implicitly broken by the introduction of many versions. I would select which ever one is most commonly used. Then bump when relevant
I probably would not bump the |
|
Ok, @jonringer, I created 2 commits:
VTK continues to be VTK8 and I created VTK_9. Just Mayavi is failing to build: $ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-95450-1/build.nix
builder for '/nix/store/20g91b052l2240ybrgmmpajp5rgf1jz6-python3.7-mayavi-4.7.1.drv' failed with exit code 139; last 10 log lines:
default: (invalid), range: None
vtkArrayNorm: Ignoring method: Get/SetWindow
default: [0, 9223372036854775807), range: None
vtkChart: Ignoring method: Get/SetSize
default: [0.0, 0.0, 0.0, 0.0], range: None
vtkChartXYZ: Ignoring method: Get/SetAxisColor
default: [0, 0, 0, 255], range: None
Warning: We cannot determine the trait type of vtkHigherOrderHexahedron.Order
Warning: We cannot determine the trait type of vtkHigherOrderQuadrilateral.Order
/nix/store/221cd4xfzwhw46dbjw38q6zrcxw1phdp-setuptools-setup-hook/nix-support/setup-hook: line 17: 23 Segmentation fault (core dumped) /nix/store/9hdzs3g6rb76grwzlsbxyxwxg2n0fl4a-python3-3.7.8/bin/python3.7 nix_run_setup bdist_wheel
builder for '/nix/store/d3wsd58yf6drwiflqjwpbi6pwqhkqll5-python3.8-mayavi-4.7.1.drv' failed with exit code 139; last 10 log lines:
default: (invalid), range: None
vtkArrayNorm: Ignoring method: Get/SetWindow
default: [0, 9223372036854775807), range: None
vtkChart: Ignoring method: Get/SetSize
default: [0.0, 0.0, 0.0, 0.0], range: None
vtkChartXYZ: Ignoring method: Get/SetAxisColor
default: [0, 0, 0, 255], range: None
Warning: We cannot determine the trait type of vtkHigherOrderHexahedron.Order
Warning: We cannot determine the trait type of vtkHigherOrderQuadrilateral.Order
/nix/store/0vlj6iv2735hxwssc15q2yrsirxfjcy1-setuptools-setup-hook/nix-support/setup-hook: line 17: 23 Segmentation fault (core dumped) /nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/bin/python3.8 nix_run_setup bdist_wheel
cannot build derivation '/nix/store/ik9crw8hwqdmxw43nilh6qblyzgz2j4h-env.drv': 2 dependencies couldn't be built
[0 built (2 failed), 13 copied (39.8 MiB), 12.6 MiB DL]
error: build of '/nix/store/ik9crw8hwqdmxw43nilh6qblyzgz2j4h-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/95450
2 packages failed to build:
python37Packages.mayavi python38Packages.mayavi
3 packages built:
python37Packages.vtk python38Packages.vtk vtk_9 |
jonringer
reviewed
Aug 14, 2020
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
ofborg
bot
added
10.rebuild-darwin: 1
10.rebuild-linux: 1
and removed
6.topic: python
labels
jonringer
reviewed
Aug 15, 2020
jonringer
reviewed
Aug 15, 2020
jonringer
reviewed
Aug 15, 2020
Edit by @mweinelt: Added backticks to get a codeblock. |
jonringer
approved these changes
Aug 15, 2020
|
sorry @tfmoraes that took a while, but it's not a simple package :( EDIT: forgot to say not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds VTK9. It makes VTK9 the default. Adds VTK_8.
Motivation for this change
Add VTK9 and its Python bindings into NixOS.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)