Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.28.3 -> 2.28.4 #95432

Merged
merged 1 commit into from Aug 14, 2020
Merged

webkitgtk: 2.28.3 -> 2.28.4 #95432

merged 1 commit into from Aug 14, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Aug 14, 2020 •
edited

Motivation for this change

Version bump.
Release news: https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Aug 14, 2020
@worldofpeace
Copy link
Contributor

Don't we typically push this to staging because of how long it takes to build everything because of it?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 14, 2020

Not sure, not many things depend on it though. Maybe staging-next is fine if we are concerned about people running GNOME from master.

@worldofpeace
Copy link
Contributor

I guess not staging from looking at the last few merges 8a339b4 6cbf2e1 9d6f01a

@worldofpeace worldofpeace merged commit 4301143 into NixOS:master Aug 14, 2020
@worldofpeace
Copy link
Contributor

@dasj19 I noticed you didn't check with sandboxing. IIRC that has been on by default the last few releases.

@dasj19
Copy link
Contributor Author

dasj19 commented Aug 14, 2020

@worldofpeace do you mean the first checkbox in the description? Tested with sandboxing? I did not do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasj19 @worldofpeace @jtojnar