Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sile: 0.10.9 → 0.10.10 #95445

Merged
merged 3 commits into from Aug 15, 2020
Merged

sile: 0.10.9 → 0.10.10 #95445

merged 3 commits into from Aug 15, 2020

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Aug 14, 2020

Motivation for this change

Upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alerque alerque mentioned this pull request Aug 14, 2020
Closed
18 tasks
@alerque alerque marked this pull request as ready for review August 14, 2020 18:34
@ofborg ofborg bot added the 6.topic: lua label Aug 14, 2020
@ofborg ofborg bot requested review from doronbehar and marsam August 14, 2020 19:06
@doronbehar
Copy link
Contributor

Diff LGTM and CI is happy at least as I am :). @alerque did you install Nix / NixOS?

@alerque
Copy link
Contributor Author

alerque commented Aug 14, 2020

@doronbehar I spun up a VM a while back and poked around, and today a Docker container (which is how I got the nonstandard checksum format for this PR) but no I'm not much of a user yet.

@marsam marsam merged commit 3a54222 into NixOS:master Aug 15, 2020
@alerque alerque deleted the sile-0.10.10 branch September 25, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alerque @doronbehar @marsam