Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord-canary: 0.0.106 -> 0.0.111 #95506

Merged
merged 1 commit into from Aug 15, 2020
Merged

discord-canary: 0.0.106 -> 0.0.111 #95506

merged 1 commit into from Aug 15, 2020

Conversation

ldesgoui
Copy link
Contributor

@ldesgoui ldesgoui commented Aug 15, 2020 •
edited

Closes #95375 which picked the wrong commit message
Closes #95376 which is already outdated

Motivation for this change

App is broken if not up to date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Result of nixpkgs-review pr 95506 1

1 package built:
- discord-canary

@bhipple bhipple merged commit 47af1cc into NixOS:master Aug 15, 2020
@ldesgoui ldesgoui deleted the update-discord-canary branch August 15, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldesgoui @bhipple