Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathics: remove package, module and test #95505

Merged
merged 3 commits into from Aug 16, 2020
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 15, 2020

The mathics package has been broken for quite some time, uses python 2, and the required django version is long gone as well. Remove the package, module and the test (which still uses the perl test driver)

Fixes #80055

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The mathics package is unmaintained and doesn't build. Remove the test
using it.
@flokli flokli requested a review from tfc August 15, 2020 14:21
@flokli flokli changed the title mathics: remove module mathics: remove package, module and test Aug 15, 2020
@mweinelt mweinelt requested a review from benley August 15, 2020 15:53
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK by me, I haven't used mathics for a long time now. I'm sure it can be resurrected if anyone really misses it.

@benley
Copy link
Member

benley commented Aug 16, 2020

...that said, it looks like mathics itself is not unmaintained. The current upstream repo supports up to django 1.11 and requires python >= 3.3, so we could make it work again pretty easily if anyone wants it.

@flokli
Copy link
Contributor Author

flokli commented Aug 16, 2020

Let's remove it for now - we can always revert if someone takes up maintainership.

@flokli flokli merged commit 16fc531 into NixOS:master Aug 16, 2020
@flokli flokli deleted the remove-mathics branch August 16, 2020 16:42
@collares collares mentioned this pull request Jan 5, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixosTests.mathics is broken
3 participants