Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fractal: 4.2.2 → 4.4.0 #95465

Merged
merged 1 commit into from Aug 15, 2020
Merged

fractal: 4.2.2 → 4.4.0 #95465

merged 1 commit into from Aug 15, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 15, 2020

Motivation for this change

https://gitlab.gnome.org/GNOME/fractal/-/blob/4.4.0/fractal-gtk/res/org.gnome.Fractal.metainfo.xml.in.in#L21-49

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Result of nixpkgs-review pr 95465 1

1 package failed to build:
- fractal

@worldofpeace
Copy link
Contributor

Result of nixpkgs-review pr 95465 1
1 package failed to build:

  • fractal

it passed on the CI though...

@worldofpeace
Copy link
Contributor

This thing also takes a while to build.

@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

Result of nixpkgs-review pr 95465 1

1 package built:
- fractal

@bhipple bhipple merged commit d8e0ade into NixOS:master Aug 15, 2020
@jtojnar jtojnar deleted the fractal-4.4 branch August 15, 2020 02:30
@bhipple
Copy link
Contributor

bhipple commented Aug 15, 2020

My first build failed because my laptop ran out of hard drive space :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants