Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesos: remove package, module and test (and chronos/marathon which depends on it) #95507

Merged
merged 8 commits into from Aug 16, 2020
Merged

mesos: remove package, module and test (and chronos/marathon which depends on it) #95507

merged 8 commits into from Aug 16, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 15, 2020

This removes mesos, its NixOS module, and the NixOS test.

It also removes chronos, marathon (and their modules), as they depend on the mesos derivation.

This has all been broken for more than 9 months, and we don't need to carry it around in such a broken state.

If someone decides to pick this up, it can be reintroduced.

Fixes #78557.

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
spark: build without mesos support
0f4b32d 
The mesos package has been broken for >9 months, it doesn't make much
sense to have the spark package depend on it (and thus being broken) by
default.
@flokli
nixosTests.mesos: remove
3c65c53 
The `mesos` package has been broken for >9 months.
@flokli flokli requested a review from grahamc August 15, 2020 14:54
@flokli flokli mentioned this pull request Aug 15, 2020
Closed
@flokli flokli requested a review from tfc August 15, 2020 14:58
@flokli
nixos/mesos*: remove
34d91a8 
The mesos package has been broken for >9 months.
@flokli
mesos: remove package
fadb45e 
It has been broken for >9 months.
@flokli
nixos/chronos: remove module
a90b929 
The chronos package has been broken for > 9 months due to the breakage
of the mesos package.
@flokli
chronos: remove package
b4eebe4 
This failed to build for >9 months, as mesos failed to build for >9
months.
@flokli
nixos/marathon: remove module
645ea78 
The corresponding package failed to build for >9 months.
@flokli
marathon: remove package
550abe9 
This failed to build for >9 months.
@tfc tfc mentioned this pull request Aug 15, 2020
Closed
@flokli flokli changed the title Remove mesos mesos: remove package, module and test (and chronos/marathon which depends on it) Aug 15, 2020
@flokli flokli merged commit b2f3bbd into NixOS:master Aug 16, 2020
@flokli flokli deleted the remove-mesos branch August 16, 2020 12:46
@flokli flokli mentioned this pull request Aug 17, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@tfc tfc Awaiting requested review from tfc

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesos is broken
2 participants
@flokli @kamilchm