Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asyncpg: 0.20.1 -> 0.21.0 (fixing CVE-2020-17446) #95499

Merged
merged 1 commit into from Aug 15, 2020
Merged

pythonPackages.asyncpg: 0.20.1 -> 0.21.0 (fixing CVE-2020-17446) #95499

merged 1 commit into from Aug 15, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 15, 2020

Motivation for this change

Fixes https://nvd.nist.gov/vuln/detail/CVE-2020-17446

Some reverse dependencies on darwin are already broken due to other issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Aug 15, 2020

@GrahamcOfBorg eval
@GrahamcOfBorg build python37Packages.asyncpg python38Packages.asyncpg python37Packages.starlette python37Packages.orm python37Packages.databases

@risicle risicle changed the title pythonPackages.asyncpg: 0.20.1 -> 0.21.0 pythonPackages.asyncpg: 0.20.1 -> 0.21.0 (fixing CVE-2020-17446) Aug 15, 2020
@ofborg ofborg bot requested a review from eadwu August 15, 2020 12:44
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95499 1

11 packages built:
- python37Packages.asyncpg
- python37Packages.databases
- python37Packages.fastapi
- python37Packages.orm
- python37Packages.starlette
- python38Packages.asyncpg
- python38Packages.databases
- python38Packages.fastapi
- python38Packages.orm
- python38Packages.starlette
- sourcehut.listssrht

@mweinelt mweinelt merged commit acea99b into NixOS:master Aug 15, 2020
@risicle
Copy link
Contributor Author

risicle commented Aug 15, 2020

👍 I should be able to identify the patches for stable.

@risicle risicle mentioned this pull request Aug 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @mweinelt