Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong documentation for word_select #474

Closed
DaKnig opened this issue Aug 15, 2020 · 1 comment
Closed

wrong documentation for word_select #474

DaKnig opened this issue Aug 15, 2020 · 1 comment
Labels
bug
Milestone
0.3

Comments

@DaKnig
Copy link

DaKnig commented Aug 15, 2020

from the language guide:

nMigen operation | Equivalent Python code
a.word_select(b, i) | a[b*i:b*i+i]

I think that should actually be a[b*i:b*(i+1)]
@whitequark whitequark added the bug label Aug 15, 2020
@whitequark
Copy link
Member

Hm, no; the documentation is technically correct. However, the variable names are confusing, since i isn't an index (in fact it is a width). Confusing docs are still a bug though so I'll fix that.

@whitequark whitequark added this to the 0.3 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
0.3
Development

No branches or pull requests
2 participants
@whitequark @DaKnig