linuxPackages.rtl8192eu: 4.4.1.20190319 -> 4.4.1.20200620 #95497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR definitely solves my problem described in #95448. And it worked with 4.19 as well as latest. As the laptop is very slow to rebuild (took 30 minutes each) I haven't tried more kernel versions to boot into this module. |
NobbZ
approved these changes
Aug 17, 2020
|
Result of 2 packages marked as broken and skipped:- linuxPackages_hardkernel_4_14.rtl8192eu - linuxPackages_hardkernel_latest.rtl8192eu 15 packages built:- linuxPackages-libre.rtl8192eu - linuxPackages.rtl8192eu (linuxPackages_5_4.rtl8192eu) - linuxPackages_4_14.rtl8192eu - linuxPackages_4_19.rtl8192eu - linuxPackages_4_4.rtl8192eu - linuxPackages_4_9.rtl8192eu - linuxPackages_5_7.rtl8192eu (linuxPackages_latest.rtl8192eu) - linuxPackages_hardened.rtl8192eu - linuxPackages_latest-libre.rtl8192eu - linuxPackages_latest_hardened.rtl8192eu - linuxPackages_latest_xen_dom0.rtl8192eu - linuxPackages_latest_xen_dom0_hardened.rtl8192eu - linuxPackages_testing_bcachefs.rtl8192eu - linuxPackages_xen_dom0.rtl8192eu - linuxPackages_xen_dom0_hardened.rtl8192eu |
|
@troydm I wonder why you said I'd need |
|
@mweinelt it's needed during build process to determine something. Honestly I don't remember which thing it determines but if it's not there you'll see error message in build log, process won't stop tho and module will be built anyway, but it's good to have less errors Following is snippet to add it: { stdenv, lib, fetchFromGitHub, kernel, bc }: buildInputs = [ bc ]; |
|
Got it. |
Fixes NixOS#95448 Co-Authored-By: Dmitry Geurkov <d.geurkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Relates to #95448
I own no such device, I just did a compile test.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)