Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.mutter: 3.36.4 -> 3.36.5 #95474

Merged
merged 1 commit into from Aug 17, 2020
Merged

gnome3.mutter: 3.36.4 -> 3.36.5 #95474

merged 1 commit into from Aug 17, 2020

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for gnome3.mutter is: "A window manager for GNOME"

meta.homepage for gnome3.mutter is: "https://gitlab.gnome.org/GNOME/mutter"

meta.changelog for gnome3.mutter is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
52 total rebuild path(s)

18 package rebuild(s)

18 x86_64-linux rebuild(s)
17 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
17 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
adapta-gtk-theme
chrome-gnome-shell
gnome3.gnome-control-center
gnome3.gnome-session
gnome3.gnome-shell
gnome3.gnome-terminal
gnome3.gnome-tweak-tool
gnome3.gnome-tweaks
gnome3.gnome_control_center
gnome3.gnome_session
gnome3.gnome_shell
gnome3.gnome_terminal
gnome3.gpaste
gnome3.mutter
gnome3.pomodoro
gnomeExtensions.gsconnect
gnomeExtensions.system-monitor
pantheon.elementary-session-settings
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/j7j4gaj1hll48w9np946in2x6vz8h3h8-mutter-3.36.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gnome3.mutter https://github.com/r-ryantm/nixpkgs/archive/31c71dd805dfd7d5926eb2db0577487c59df2291.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/j7j4gaj1hll48w9np946in2x6vz8h3h8-mutter-3.36.5
ls -la /nix/store/j7j4gaj1hll48w9np946in2x6vz8h3h8-mutter-3.36.5/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

13 packages built:
  • adapta-gtk-theme
  • chrome-gnome-shell
  • gnome3.gnome-control-center
  • gnome3.gnome-session
  • gnome3.gnome-shell
  • gnome3.gnome-terminal
  • gnome3.gnome-tweak-tool
  • gnome3.gpaste
  • gnome3.mutter
  • gnome3.pomodoro
  • gnomeExtensions.gsconnect
  • gnomeExtensions.system-monitor
  • pantheon.elementary-session-settings
Maintainer pings

cc @hedning @jtojnar @worldofpeace @dasj19 for testing.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 15, 2020
jtojnar
jtojnar approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay:

3.36.5

  • Screencast fixes and improvements [Jonas; !1351, !1365]
  • Fix glitches when subsurfaces extend outside the toplevel [Robert; #1316]
  • Mipmap background texture rendering [Daniel; !1347]
  • Fix wine copy & paste [Sebastian; !1369]
  • Plugged memory leaks [Marco, Thomas; !1195]

Contributors:
Jonas Ådahl, Thomas Hindoe Paaboel Andersen, Sebastian Keller, Robert Mader,
Marco Trevisan (Treviño), Daniel van Vugt

Translators:
Rafael Fontenelle [pt_BR]

@jtojnar
Copy link
Contributor

jtojnar commented Aug 15, 2020 •
edited

@GrahamcOfBorg test gnome3 gnome3-xorg

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Aug 15, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 17, 2020

Test failed but it is not clear to me why. Trying again.

@GrahamcOfBorg test gnome3

@dasj19
Copy link
Contributor

dasj19 commented Aug 17, 2020

Maybe we need to update gnome-shell as well... there is a release ready for that package as well... I'll do a separate PR for that.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 17, 2020

The test succeeded now so merging.

@jtojnar jtojnar merged commit 496818f into NixOS:master Aug 17, 2020
@r-ryantm r-ryantm deleted the auto-update/mutter branch August 18, 2020 08:57
@jtojnar
Copy link
Contributor

jtojnar commented Aug 19, 2020 •
edited

The test seems to be blocking unstable channel now, even though it passed here.

https://hydra.nixos.org/build/125573530

I can also reproduce the failure locally using nix-build -A nixosTests.gnome3. And when I revert 496818f, it seems to work again. Consistently.

I tried bisecting mutter itself but it does not seem to make much sense:

# bad: [7d061a06dec02278bef1054e502cae8837c39f2f] Bump version to 3.36.5
# good: [d03deb006c4154232ee257a8a16fee4ea61f3286] Bump version to 3.36.4
git bisect start '3.36.5' '3.36.4'
# bad: [ef3dac70648196de8e291708eaa1cf68dc2eec28] Update Brazilian Portuguese translation
git bisect bad ef3dac70648196de8e291708eaa1cf68dc2eec28
# bad: [2d899596e21d43ab241d0ba37c0a9f90c2e610be] screen-cast/src: Make record functions return an error when failing
git bisect bad 2d899596e21d43ab241d0ba37c0a9f90c2e610be
# bad: [b1d45820efc5c9136f12d8a3b97a573a2eede9e7] screen-cast/window-stream-src: Fix indentation
git bisect bad b1d45820efc5c9136f12d8a3b97a573a2eede9e7
# bad: [d07335cd4ca094d790eac75e75cff01a28fda827] screen-cast-src: Make the two record vfuncs more similarly named
git bisect bad d07335cd4ca094d790eac75e75cff01a28fda827
# first bad commit: [d07335cd4ca094d790eac75e75cff01a28fda827] screen-cast-src: Make the two record vfuncs more similarly named

@jtojnar
Copy link
Contributor

jtojnar commented Aug 19, 2020

Tried reverting it on master but it does not seem to fix it there 😕

@jtojnar
Copy link
Contributor

jtojnar commented Aug 19, 2020

I am now consistently getting the Failed to parse arguments: Cannot open display error even on channels/nixos-unstable 🙀

@hedning
Copy link
Contributor

hedning commented Aug 19, 2020

The test is probably just a bit flaky (IIRC that's been an issue a while). Tested on channels/nixos-unstable and have gotten failures and success.

The failure on hydra indicates that the dbus session might not be up yet? We probably need a better way to wait for gnome-shell to be properly set up.

Doing some digging now.

@worldofpeace
Copy link
Contributor

The failure on hydra indicates that the dbus session might not be up yet? We probably need a better way to wait for gnome-shell to be properly set up.

Yep, that is entirely the problem. The only thing better would be to actually extend the testing driver.

@hedning
Copy link
Contributor

hedning commented Aug 23, 2020

Tried a few things without real success:

  • waiting on gnome-session.target
  • waiting on gnome-session-initialized.target
  • and waiting on dbus.service/socket

The test have been passing on hydra now, but it's fairly annoying that it isn't consistent.

We could perhaps just install an autostart file for gnome-terminal, that might be more robust?

@hedning
Copy link
Contributor

hedning commented Aug 23, 2020

OK, autostart file looks promising, will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@dasj19 dasj19 dasj19 approved these changes

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @jtojnar @dasj19 @hedning @worldofpeace