New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.wxpython_4_1: init at 4.1.0 #95462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we already have a wxPYTHON_4_0
, it would probably be best to only keep one of each major version (unless the package causes breakages between minor versions as well)
There are a lot of change between wxpython4.0.x and wxpython4.1.x. For instance wxWidgets/Phoenix#1612 |
|
does this package expose the wxWidgets version it built? |
@evils it doesn't. I have this pull request to package wx3.1.4 #95460 . In this commit wxPython starts to use wx3.1.4 wxWidgets/Phoenix@57702fa#diff-abf77184f55403d75b9d51d79162a7ca |
i'm not sure why you're mentioning that |
@evils I was thinking in package that git-committed version of wxpython, but it's a bad idea. But I managed to compile wxPython-4.1.0 with wxWidgets-3.1.4 in my branch here https://github.com/tfmoraes/nixpkgs/tree/wxgtk314_wxpython411 . Maybe if fix your problem. |
@tfmoraes your wxPython 4.1.0 with wxWidgets 3.1.4 branch solves kicad issue 4431 :D |
@evils @jonringer what is better?
|
f286d6f
to
708068b
Compare
708068b
to
6c9c1a6
Compare
539ffce
to
4f826b4
Compare
I would just combine the two PRs, you can use either, just make a comment saying what you decide |
Since this seems to copy the previous wxPython package, have you taken into account #94108? |
("appsvc", None) | ||
]}' | ||
|
||
# https://github.com/wxWidgets/Phoenix/pull/1584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably better to refer to wxWidgets/Phoenix#1699 as that indicates this change has been upstreamed and can probably be removed at a later point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, in the other PR #98951
Hi @jonringer, I created a new PR with wxWidgets + wxPython #98951 |
Motivation for this change
Add WXPython-4.1.0 to NixOS. The package is compiling its own wxgtk because wxpython is not compiling with it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)