nixos/displayManager: add XDG_SESSION_ID to systemd user environment #93764
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenbrenden
force-pushed
the
xdg-session-id-user-units
branch
2 times, most recently
from
9b3ab47 to
235dc5c
Compare
ofborg
bot
added
6.topic: nixos
misuzu
approved these changes
Jul 24, 2020
evenbrenden
force-pushed
the
xdg-session-id-user-units
branch
from
235dc5c to
58773b3
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
flokli
reviewed
Sep 5, 2020
xss-lock needs XDG_SESSION_ID to respond to loginctl lock-session(s) (and possibly other session operations such as idle hint management). This change adds XDG_SESSION_ID to the list of imported environment variables when starting systemctl. Inspired by home-manager, add importVariables configuration. Set session to XDG_SESSION_ID when running xss-lock as a service. Co-authored-by: misuzu <bakalolka@gmail.com>
evenbrenden
force-pushed
the
xdg-session-id-user-units
branch
from
58773b3 to
660882d
Compare
|
@ofborg eval |
flokli
approved these changes
Sep 6, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-config-hybrid-sleep-after-idle-and-lock/8728/12 |
hedning
approved these changes
Sep 8, 2020
|
As far as I understand, the grahamcofborg-eval-nixpkgs-unstable-jobset failure was #97170, which is closed and unrelated. @worldofpeace does it make sense to trigger another eval? |
|
@ofborg eval |
|
Yep |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revamp of @misuzu's #67751, with SLiM changes omitted and xss-lock changes added.
Motivation for this change
xss-lock needs
XDG_SESSION_IDto respond tologinctl lock-session(and possibly other session operations such as idle hint management). Tested with LightDM.Things done
Add
XDG_SESSION_IDto the list of imported environment variables when starting systemctl.Inspired by home-manager, add
importVariablesconfiguration.Set session to
XDG_SESSION_IDwhen running xss-lock as a service.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)