Fix onbeforexrselect event handler inheritance #24747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 24, 2020
|
@stephenmcgruer FYI - the idlharness test you added spotted an implementation inconsistency in Chromium. I added some instance objects but I'm not really familiar with how those are supposed to work, please let me know on https://chromium-review.googlesource.com/2317813 or here if you have feedback on that. |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2317813
branch
3 times, most recently
from
2403575
to
e3cd40f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2317813
branch
from
e3cd40f
to
a46f2f6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2317813
branch
from
a46f2f6
to
e1c9298
Compare
The onbeforexrselect event is supposed to be part of GlobalEventHandlers
and separately inherited by {HTML,MathML,SVG}Element, Window, and
Document. The current implementation had added it at the Element
level which isn't correct, causing test failures in the idlharness
test.
Update the implementation to fix the inheritance, which unfortunately
adds a bit of extra boilerplate.
Also add objects to the idlharness test to verify the inheritance.
Spec: https://immersive-web.github.io/dom-overlays/#onbeforexrselect
Fixed: 1108685
Change-Id: I8df73304b7b2d9bd93df30b78953aa9b378f8cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317813
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846294}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2317813
branch
from
e1c9298
to
f127658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onbeforexrselect event is supposed to be part of GlobalEventHandlers
and separately inherited by {HTML,MathML,SVG}Element, Window, and
Document. The current implementation had added it at the Element
level which isn't correct, causing test failures in the idlharness
test.
Update the implementation to fix the inheritance, which unfortunately
adds a bit of extra boilerplate.
Also add objects to the idlharness test to verify the inheritance.
Spec: https://immersive-web.github.io/dom-overlays/#onbeforexrselect
Fixed: 1108685
Change-Id: I8df73304b7b2d9bd93df30b78953aa9b378f8cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317813
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846294}