Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9db881d6cb7c
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 826d8f4299b4
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 24, 2020

  1. cli: fix analyzer crash on 0-wide fields.

    @whitequark
    whitequark committed Jul 24, 2020
    Copy the full SHA
    0ede862 View commit details

  2. access.direct.arguments: add support for empty pin sets.

    @whitequark
    whitequark committed Jul 24, 2020
    Copy the full SHA
    ad32342 View commit details

  3. applet.memory.prom: new applet, replacing memory.27x. 

    The applet has been completely rewritten with a nicer implementation,
dramatically improved performance, and support for indirectly
addressing memories with many address lines through a shift register.
    @whitequark
    whitequark committed Jul 24, 2020
    Copy the full SHA
    826d8f4 View commit details
9 changes: 7 additions & 2 deletions software/glasgow/access/direct/arguments.py
View file
Original file line number Diff line number Diff line change
@@ -65,7 +65,9 @@ def _add_pin_argument(self, parser, name, default, required):
opt_name, metavar="NUM", type=type, default=default, required=required, help=help)

def _pin_set(self, width, arg):
if re.match(r"^[0-9]+:[0-9]+$", arg):
if arg == "":
numbers = []
elif re.match(r"^[0-9]+:[0-9]+$", arg):
first, last = map(int, arg.split(":"))
numbers = list(range(first, last + 1))
elif re.match(r"^[0-9]+(,[0-9]+)*$", arg):
@@ -84,7 +86,10 @@ def _pin_set(self, width, arg):
def _add_pin_set_argument(self, parser, name, width, default, required):
help = "bind the applet I/O lines {!r} to pins SET".format(name)
if default is not None:
help += " (default: %(default)s)"
if default:
help += " (default: %(default)s)"
else:
help += " (default is empty)"

opt_name = "--pins-" + name.lower().replace("_", "-")
parser.add_argument(
2 changes: 1 addition & 1 deletion software/glasgow/applet/all.py
View file
Original file line number Diff line number Diff line change
@@ -15,8 +15,8 @@

from .memory._24x import Memory24xApplet
from .memory._25x import Memory25xApplet
from .memory._27x import Memory27xApplet
from .memory.onfi import MemoryONFIApplet
from .memory.prom import MemoryPROMApplet
from .memory.floppy import MemoryFloppyApplet

from .debug.arc import DebugARCApplet
171 changes: 0 additions & 171 deletions software/glasgow/applet/memory/_27x/__init__.py
View file

This file was deleted.

Loading