Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SL1ToPhoton: init at 0.1.3 #93792

Merged
merged 2 commits into from Jul 31, 2020
Merged

SL1ToPhoton: init at 0.1.3 #93792

merged 2 commits into from Jul 31, 2020

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Jul 25, 2020 •
edited

Motivation for this change

I needed this to convert files from Prusa SL1 to Photon format. This is needed for PrusaSlicer export to work with any printers using cbddip format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Jul 25, 2020
View reviewed changes
pkgs/applications/misc/sl1-to-photon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/sl1-to-photon/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyphotonfile/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@cab404 cab404 requested a review from prusnak July 27, 2020 13:17
prusnak
prusnak requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the changes into two commits having the following commit messages:

python3Packages.pyphotonfile: init at 0.2.1

sl1-to-photon: init at 0.1.3

as documented in CONTRIBUTING.md

@cab404
Copy link
Member Author

cab404 commented Jul 27, 2020

as documented in CONTRIBUTING.md

Contributing specifies following commit message format

Please squash the changes into two commits having the following commit messages:

python3Packages.pyphotonfile: init at 0.2.1

sl1-to-photon: init at 0.1.3

as documented in CONTRIBUTING.md

done

@cab404
Copy link
Member Author

cab404 commented Jul 27, 2020

Done

Not really: You did not include python3Packages in python3Packages.pyphotonfile: init at 0.2.1

done

@prusnak
Copy link
Member

prusnak commented Jul 27, 2020

Thanks!

@cab404 cab404 changed the title Packaged SL1ToPhoton SL1ToPhoton: init at 0.1.3 Jul 30, 2020
@balsoft balsoft merged commit 6fb6633 into NixOS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cab404 @prusnak @lovesegfault @balsoft