Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeql: 2.2.3 -> 2.2.4 #93776

Merged
merged 1 commit into from
Jul 24, 2020
Merged

codeql: 2.2.3 -> 2.2.4 #93776

merged 1 commit into from
Jul 24, 2020
+2 −2

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Have the latest version of codeql available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Pamplemousse Pamplemousse requested a review from jollheef July 24, 2020 16:02
@Pamplemousse
codeql: 2.2.3 -> 2.2.4
d14d094 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 24, 2020
danieldk
danieldk approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93776 1

1 package built:
- codeql

The binary is functional

@danieldk danieldk merged commit deeb49e into NixOS:master Jul 24, 2020
@Pamplemousse Pamplemousse deleted the codeql branch July 28, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk

@jollheef jollheef

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @danieldk