Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblinear: 2.30 -> 2.40 #93759

Merged
merged 1 commit into from Jul 31, 2020
Merged

liblinear: 2.30 -> 2.40 #93759

merged 1 commit into from Jul 31, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Also improve the derivation a bit:

  • Use fetchFromGitHub in place of fetchurl.
  • Replace buildPhase by buildFlags.
  • Create multiple outputs.
  • Replace mkdir/cp by install.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
liblinear: 2.30 -> 2.40
0e29fcd 
Also improve the derivation a bit:

- Use fetchFromGitHub in place of fetchurl.
- Replace buildPhase by buildFlags.
- Create multiple outputs.
- Replace mkdir/cp by install.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/237

doronbehar
doronbehar reviewed Jul 31, 2020
View reviewed changes
pkgs/development/libraries/liblinear/default.nix

stdenv.mkDerivation rec {
let
soVersion = "4";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what's upstream policy regarding this? Why wouldn't they use e.g liblinear.${version}.so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they just bump the SONAME when there is an ABI change, but they don't bump the major version.

doronbehar
doronbehar approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't built it or tested it as even if I did I wouldn't know how.

@danieldk
Copy link
Contributor Author

LGTM but I haven't built it or tested it as even if I did I wouldn't know how.

Thanks for the sanity check!

@danieldk danieldk merged commit c31de49 into NixOS:master Jul 31, 2020
@danieldk danieldk deleted the liblinear-2.40 branch July 31, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @doronbehar