Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/chromium: update link in docs #93794

Merged
merged 1 commit into from Oct 16, 2020
Merged

nixos/chromium: update link in docs #93794

merged 1 commit into from Oct 16, 2020

Conversation

tnias
Copy link
Contributor

@tnias tnias commented Jul 25, 2020

Motivation for this change

The linked documentation states the following.

The Chrome Enterprise policy list is moving! Please update your bookmarks [...]

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tnias
Copy link
Contributor Author

tnias commented Oct 3, 2020

CC person who did a similar fix @davidak

davidak
davidak approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

primeos
primeos requested changes Oct 16, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://cloud.google.com/docs/chrome-enterprise/policies would be better. At least for me https://cloud.google.com/docs/chrome-enterprise/policies/?policy=ExtensionInstallForcelist">ExtensionInstallForcelist doesn't seem to render correctly / contains less "extras".

@tnias
Copy link
Contributor Author

tnias commented Oct 16, 2020

The correct link is https://cloud.google.com/docs/chrome-enterprise/policies/?policy=ExtensionInstallForcelist without the extra ">ExtensionInstallForcelist.

The argument ?policy=ExtensionInstallForcelist opens the appropriate policy description. The link without arguments just displays a list of all policy options.

I am using Chromium Version 85.0.4183.121 (Developer Build) (64-bit) and it seems to render fine. What browser are you using?

primeos
primeos approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct link is https://cloud.google.com/docs/chrome-enterprise/policies/?policy=ExtensionInstallForcelist without the extra ">ExtensionInstallForcelist.

Ups, sorry about that, I was stupid and ignored XML while copying the link. That also explains the strange "> then 🤦

My bad. Thanks for the fix :)

@primeos primeos merged commit 0da7593 into NixOS:master Oct 16, 2020
primeos pushed a commit that referenced this pull request Oct 16, 2020
@tnias @primeos
nixos/chromium: update link in docs (#93794)
84f6c8f 
(cherry picked from commit 0da7593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@davidak davidak davidak approved these changes

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tnias @prusnak @davidak @primeos