Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.haskell-language-server: 0.2.0.0 -> 0.2.2.0 #93768

Merged
merged 1 commit into from
Jul 24, 2020
Merged

[haskell-updates] haskellPackages.haskell-language-server: 0.2.0.0 -> 0.2.2.0 #93768

merged 1 commit into from
Jul 24, 2020
+37 −36

Conversation

maralorn
Copy link
Member

This bumps the version of hls. And disables one of the tests.

In my opinion, this can and should be merged with the failing test for now, as the newer version contains a lot of compatibility fixes.

I have contacted upstream about the failing test. But for now, I don‘t know how to fix it.

@GuillaumeDesforges maybe you have an idea?

Test suite wrapper-test: RUNNING...
haskell-language-server-wrapper
  --project-ghc-version
    stack with ghc 8.10.1: FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)
    stack with ghc 8.8.3:  FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)
    cabal with global ghc: FAIL
      Exception: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)

3 out of 3 tests failed (0.07s)
Test suite wrapper-test: FAIL
Test suite logged to:
dist/test/haskell-language-server-0.2.2.0-wrapper-test.log
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@maralorn maralorn requested a review from cdepillabout as a code owner July 24, 2020 13:15
@maralorn maralorn changed the title haskellPackages.haskell-language-server: 0.2.0.0 -> 0.2.2.0 [haskell-updates] haskellPackages.haskell-language-server: 0.2.0.0 -> 0.2.2.0 Jul 24, 2020
@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.haskell-language-server

cdepillabout
cdepillabout approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@maralorn maralorn merged commit 359d2e6 into NixOS:haskell-updates Jul 24, 2020
@maralorn maralorn deleted the hls branch July 24, 2020 13:54
@GuillaumeDesforges
Copy link
Contributor

Yup, had some issues about that already, let me get to it

@maralorn
Copy link
Member Author

@GuillaumeDesforges Nice! Thanks!

@GuillaumeDesforges
Copy link
Contributor

@maralorn did you submit an upstream issue?

@maralorn
Copy link
Member Author

@GuillaumeDesforges, I am sorry, no. I had a chat with lukelau in the hls freenode room. The issue seems to be simple and generic. The test needs the binary in the PATH and they wrote a hack accessing dist-newstyle to discover the binaries. They consider it a bug. They encouraged me to fix it because they were were. Busy, but I am also on holidays so I forgot about. You can pick between making a simple PR to hls, opening an issue or waiting for me or then to fix it. Although the latter might be risky without an issue...

@GuillaumeDesforges
Copy link
Contributor

I'll make an issue, I can't take this atm. It can wait anyway

@GuillaumeDesforges GuillaumeDesforges mentioned this pull request Jul 29, 2020
Closed
@GuillaumeDesforges
Copy link
Contributor

Apparently fixed: haskell/haskell-language-server#251 (comment)

Let's update upstream issue on the next version bump of our nixpkgs hls derivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maralorn @GuillaumeDesforges @cdepillabout