Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell-updates] bluespec: Fix build without ghc 844 #93772

Merged
merged 1 commit into from Jul 24, 2020

Conversation

maralorn
Copy link
Member

ghc 8.4.4 was only required before the merge of

B-Lang-org/bsc#42

which actually is already contained in the commit we are using.

Motivation for this change

This fixes bluespec and the issues we had with ofBorg in the last days.

\cc @peti @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ghc 8.4.4 was only required before the merge of

B-Lang-org/bsc#42

which actually is already contained in the commit we are using.
@maralorn
Copy link
Member Author

@GrahamcOfBorg build bluespec

@maralorn maralorn changed the title bluespec: Fix build without ghc 844 [haskell-updates] bluespec: Fix build without ghc 844 Jul 24, 2020
@peti peti merged commit 5f8e67b into NixOS:haskell-updates Jul 24, 2020
@maralorn maralorn deleted the fix-bluespec branch July 24, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants