[20.03] element-{web,desktop}: backport version bump & rename #93773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Hmm right, |
|
Since Electron 9 is not in 20.03 but Electron 8 is, it might be worthwhile to use that, at least for the backport. |
bachp
approved these changes
Jul 25, 2020
It used to work with this version and `electron_9` isn't available on 20.03.
(cherry picked from commit 2d468be)
|
Latest push should fix eval, also using |
|
@NixOS/backports any objctions? |
|
No objections @Ma27 |
worldofpeace
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backports the rename of
riot-{web,desktop}toelement(#93134, #93303, #93308) that has happened during the update to1.7. Also added some warnings to advertise the use ofpkgs.element*and to mention removed feature-flags (where the features are now available by default inelement).Rationale for backport: for the matrix subsystem on NixOS we've established a backport-by-default policy to remain up-to-date with the
matrix.orginfrastructure several months ago (previosuly we experienced compat-issues with their infrastructure occasionally). Several people (including me) from the Nix-matrix channel are already usingelement-webat1.7on NixOS systems (on both unstable and 20.03) without having any issues (while using and while migrating to it), so we currently consider this backport as doable.cc @NixOS/backports @claudiiii
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)