Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.trezor: enable shell completion #93767

Merged
merged 1 commit into from Jul 24, 2020
Merged

pythonPackages.trezor: enable shell completion #93767

merged 1 commit into from Jul 24, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 24, 2020 •
edited

Generate click shell completions and copy them to the right place.

A disadvantage is that the generated files are quite minimal and rely on invoking trezorctl when completing, making this quite slow.

Motivation for this change

No shell completion for trezorctl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from mmahut, np, 1000101 and prusnak July 24, 2020 13:12
1000101
1000101 approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autocomplete tested in bash - works, although it's a tad slow (as advertised).

Running trezorctl --version got me an exception, wondering if anyone else experiences the same issues, but it's not related to this PR, I've verified it's throwing the same exception in current merged version (0.12.0)

@mmahut mmahut merged commit 1d097a6 into NixOS:master Jul 24, 2020
@mmilata mmilata deleted the trezorctl-shell-completion branch July 24, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@np np Awaiting requested review from np

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @1000101 @mmahut