Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweethome3d: improve performance by enabling OpenGL for java2d #93075

Merged
merged 1 commit into from Jul 15, 2020
Merged

sweethome3d: improve performance by enabling OpenGL for java2d #93075

merged 1 commit into from Jul 15, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Jul 13, 2020

This is a well-known optimization (see also
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854030
http://www.sweethome3d.com/support/forum/viewthread_thread,5662
https://sourceforge.net/p/sweethome3d/bugs/854/ ) and indeed also
on my machine was a drastic improvement.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo July 13, 2020 17:25
davidak
davidak approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93075".

Without this fix it is barely usable on less performant hardware. So maybe also backport it. Not sure if anyone uses it.

Here is a bathroom:
Klo

@raboof
Copy link
Member Author

raboof commented Jul 14, 2020

Tested

Thanks! (btw, I'm curious: do you also have to prepend MESA_GL_VERSION_OVERRIDE=2.1 for the application to start? I'm not sure that's needed just for me locally or for all sweethome3d@nix users)

@davidak
Copy link
Member

davidak commented Jul 14, 2020

do you also have to prepend MESA_GL_VERSION_OVERRIDE=2.1 for the application to start?

@raboof no. i'm on stable if that helps

aanderse
aanderse approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough. Merging based on testing and good word from @davidak and @raboof. Thanks!

@aanderse aanderse merged commit a3efa87 into NixOS:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@aanderse aanderse aanderse approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @davidak @aanderse