Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2_proxy: 5.1.1 -> 6.0.0 #93121

Merged
merged 1 commit into from Jul 20, 2020
Merged

oauth2_proxy: 5.1.1 -> 6.0.0 #93121

merged 1 commit into from Jul 20, 2020

Conversation

knl
Copy link
Contributor

@knl knl commented Jul 14, 2020 •
edited

Motivation for this change

The new release fixes one of the outstanding CVEs against oauth2_proxy:
GHSA-5m6c-jp6f-2vcv.

In addition rename the owner and the project name to reflect the changes upstream (it now belongs to the oauth2-proxy organization, and the name is oauth2-proxy)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knl knl requested a review from yorickvP July 14, 2020 13:55
@ofborg ofborg bot requested a review from kalbasit July 14, 2020 14:55
kalbasit
kalbasit requested changes Jul 14, 2020
View reviewed changes
pkgs/servers/oauth2_proxy/default.nix Outdated Show resolved Hide resolved
@knl
oauth2_proxy: 5.1.1 -> 6.0.0
4c5e041 
The new release fixes one of the outstanding CVEs against oauth2_proxy:
GHSA-5m6c-jp6f-2vcv.

In addition, rename the owner and the project name to reflect the
changes upstream (it now belongs to the oauth2-proxy organization, and
the name is oauth2-proxy)
@ofborg ofborg bot requested a review from kalbasit July 14, 2020 17:23
@knl
Copy link
Contributor Author

knl commented Jul 17, 2020

@kalbasit I fixed the issue, please take another look.

@kalbasit kalbasit merged commit 53f42f2 into NixOS:master Jul 20, 2020
@bbigras bbigras mentioned this pull request Sep 4, 2020
Closed
1 task
@knl knl deleted the bump-up-oauth2-proxy branch March 18, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@yorickvP yorickvP Awaiting requested review from yorickvP

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knl @kalbasit