Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.RcppParallel: Patch shebang #93079

Merged
merged 1 commit into from Jul 22, 2020
Merged

rPackages.RcppParallel: Patch shebang #93079

merged 1 commit into from Jul 22, 2020

Conversation

cfhammill
Copy link
Contributor

Fixes the build error currently on hydra

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cfhammill
rpackages.RcppParallel: Patch shebang
3c503aa 
Fixes hydra build error
@cfhammill cfhammill requested a review from peti as a code owner July 13, 2020 18:23
@cfhammill cfhammill changed the title rpackages.RcppParallel: Patch shebang rPackages.RcppParallel: Patch shebang Jul 13, 2020
@bcdarwin
Copy link
Member

@GrahamcOfBorg build rPackages.RcppParallel rPackages.rstanarm

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/189

@peti peti merged commit 64accdc into NixOS:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cfhammill @bcdarwin @nixos-discourse @peti