Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum extraction using FFT #2646

Merged
merged 7 commits into from
Jul 13, 2020
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 13, 2020

Also some tolerance fixes for Clang.

result.Include(max->first);
} else {
result.Include(std::next(max)->first);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t we include the infinite frequency (rather than just 1 cycle/Δt) when the mode is in the high frequencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that you say it, we should not look beyond the first half of transform_. The reason is that, the signal being real, the values are complex conjugate. (That's obvious in the tests.)

@eggrobin eggrobin added the LGTM label Jul 13, 2020
@pleroy pleroy merged commit 8f37471 into mockingbirdnest:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants