Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spdlog: 1.6.0 -> 1.7.0 #93098

Merged
merged 1 commit into from Sep 5, 2020
Merged

spdlog: 1.6.0 -> 1.7.0 #93098

merged 1 commit into from Sep 5, 2020

Conversation

ardumont
Copy link
Contributor

@ardumont ardumont commented Jul 14, 2020 •
edited

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS,
    • macOS
    • other: debian (stable) with nix
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size: 2581792 -> 2582608 (- 816) [1]
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1] master (before):

/nix/store/c2l6jvasisdpwz3cs7jppimpskghck4n-spdlog-0.17.0            376496
/nix/store/6f6imx474gl4kwgkz74i4pf74jyy351l-spdlog-1.6.0            2581792

after:

/nix/store/c2l6jvasisdpwz3cs7jppimpskghck4n-spdlog-0.17.0            376496
/nix/store/gx1lp0zq6sh1m9ixhx5v1c0c4hv7r51h-spdlog-1.7.0            2582608

@ardumont ardumont changed the title oospdlog: 1.6.0 -> 1.7.0 spdlog: 1.6.0 -> 1.7.0 Jul 14, 2020
@ofborg ofborg bot requested a review from obadz July 14, 2020 08:52
@doronbehar
Copy link
Contributor

You should pull master and rebase future PRs to it. Other then that I tested nheko's build (has spdlog as dep) and it's fine.

@ardumont
Copy link
Contributor Author

You should pull master and rebase future PRs to it.

yes, done.

Other then that I tested nheko's build (has spdlog as dep) and it's fine.

cool, thanks.

@ardumont ardumont mentioned this pull request Jul 16, 2020
Merged
10 tasks
r-burns
r-burns approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested dependees (incl. mtxclient, nheko, waybar) locally

pkgs/development/libraries/spdlog/default.nix Outdated Show resolved Hide resolved
@risicle
Copy link
Contributor

risicle commented Sep 5, 2020

Doesn't appear to introduce any new failures, macos 10.14.

@risicle risicle merged commit 6150ee8 into NixOS:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

@obadz obadz Awaiting requested review from obadz

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ardumont @doronbehar @risicle @r-burns