Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Gnome 3.34 updates (the sequel) #93114

Merged
merged 54 commits into from Jul 16, 2020
Merged

[20.03] Gnome 3.34 updates (the sequel) #93114

merged 54 commits into from Jul 16, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 14, 2020 •
edited

Motivation for this change

I have:

  • ran update.nix
  • excluded updates that didn't make sense
  • did one's outside the version bound that did make sense
  • did backports from master where possible

I haven't built anything, not sure if I should split this into a staging-20.03 PR and a release-20.03 PR.

This is a re-PR of #85974, but on a gnome-20.03 branch in nixpkgs because I need a hydra jobset.

https://hydra.nixos.org/jobset/nixpkgs/gnome-stable#tabs-evaluations

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

I've had @grahamc (our hero) setup a hydra jobset for this https://hydra.nixos.org/jobset/nixpkgs/gnome-stable#tabs-configuration. We should be able to get updates going for gnome on stable branches with some regularity if you target the branch gnome-20.03

@worldofpeace worldofpeace added this to In Progress in GNOME Jul 14, 2020
@worldofpeace worldofpeace mentioned this pull request Jul 14, 2020
Closed
10 tasks
@worldofpeace worldofpeace requested a review from a team July 14, 2020 13:10
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build gtk3

(hydra is doing something weird with the darwin build of gtk3, here to confirm)

@worldofpeace
Copy link
Contributor Author

@ofborg build gtk3

jtojnar
jtojnar approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the commits I would expect this to be fine, but I have already garbage collected the previous cycle from my mind. I would be wary of GTK update but the changelog looks okay except for Wayland bump (not an issue) and graphical changes (might break layout of some apps). GLib and GOM changes look okay too.

@worldofpeace
Copy link
Contributor Author

Looking at the commits I would expect this to be fine, but I have already garbage collected the previous cycle from my mind. I would be wary of GTK update but the changelog looks okay except for Wayland bump (not an issue) and graphical changes (might break layout of some apps). GLib and GOM changes look okay too.

Thanks, I think I'm going to go for it. Hopefully without a hitch 🤞

@worldofpeace worldofpeace merged commit 619d8c0 into release-20.03 Jul 16, 2020
GNOME automation moved this from In Progress to Done Jul 16, 2020
@worldofpeace worldofpeace deleted the gnome-20.03 branch July 16, 2020 20:38
@worldofpeace worldofpeace restored the gnome-20.03 branch July 16, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @r-ryantm @jonringer