Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] syncthing: 1.3.4 -> 1.6.1 #93123

Merged
merged 5 commits into from Jul 14, 2020
Merged

[20.03] syncthing: 1.3.4 -> 1.6.1 #93123

merged 5 commits into from Jul 14, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 14, 2020 •
edited

Motivation for this change

syncthing is very old, fix issue #92271.

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixosTest.syncthing-init nixosTests.syncthing-relay
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
7 packages updated:
qsyncthingtray syncthing (1.3.4 → 1.6.1) syncthing-cli (1.3.4 → 1.6.1) syncthing-discovery (1.3.4 → 1.6.1) syncthing-gtk syncthing-gtk syncthing-relay (1.3.4 → 1.6.1)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/rnhmjoj/.cache/nixpkgs-review/pr-93123-1/build.nix
[6 built, 54 copied (169.9 MiB), 33.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/93123
6 packages built:
python27Packages.syncthing-gtk qsyncthingtray syncthing syncthing-cli syncthing-discovery syncthing-relay

@rnhmjoj rnhmjoj requested a review from marsam July 14, 2020 13:58
@marsam marsam linked an issue Jul 14, 2020 that may be closed by this pull request
syncthing is broken in stable #92271
Closed
@marsam marsam merged commit e69cfc3 into NixOS:release-20.03 Jul 14, 2020
@rnhmjoj rnhmjoj deleted the syncthing-20.03 branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@andrew-d andrew-d Awaiting requested review from andrew-d

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syncthing is broken in stable
2 participants
@rnhmjoj @marsam