Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/moodle: add plugins #93104

Merged
merged 2 commits into from Jul 17, 2020
Merged

nixos/moodle: add plugins #93104

merged 2 commits into from Jul 17, 2020

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jul 14, 2020

Motivation for this change

Support Plugins for moodle

Things done

Upgraded moodle to 3.9.1 and add a plugin attribute to install plugins into moodle.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC: @aanderse

@ofborg ofborg bot requested a review from aanderse July 14, 2020 11:05
@Kloenk Kloenk marked this pull request as draft July 14, 2020 11:24
@Kloenk Kloenk force-pushed the moodle-plugins branch 2 times, most recently from 9a03adf to 544b6a4 Compare July 14, 2020 11:50
@Kloenk Kloenk marked this pull request as ready for review July 14, 2020 13:13
@Kloenk Kloenk force-pushed the moodle-plugins branch 3 times, most recently from 4bb11c8 to cb0e913 Compare July 14, 2020 15:01
@Kloenk
Copy link
Member Author

Kloenk commented Jul 14, 2020

The moodle self check no only only complains about opcache. But this is a setting for the php.ini configuration. Not sure if we want to touch that

@Kloenk
Copy link
Member Author

Kloenk commented Jul 16, 2020

rebased to resolve conflict

@Lassulus Lassulus merged commit b6eca9a into NixOS:master Jul 17, 2020
@Kloenk Kloenk mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kloenk @Lassulus