Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0e93ae3f67c8
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a224b6e18fa7
Choose a head ref
  • 18 commits
  • 7 files changed
  • 2 contributors

Commits on Jul 12, 2020

  1. Copy the full SHA
    2d2b751 View commit details
    Browse the repository at this point in the history
  2. lvm2: cleanups, make udev optional

     - use installTargets again ("install", and
       "install_systemd_{generators,units,configuration}" when udev is not
       null)
     - The call to the blkid binary in lvm2's 13-dm-disk.rules file
       disappeared (so we don't need to patch in blkid anymore).
       lvm seems to rely on udev's internal blkid functionality.
     - Call /run/current-system/systemd/bin/udevadm instead
       of ${systemd}/bin/udevadm in the lvm activation generator.
       This is not necessary to break the dependency cycle (as we don't use
       that file when building without udev), but a good idea anyways -
       We want to trigger the udevadm of the current system, not the one
       that lvm was built with.
    flokli committed Jul 12, 2020
    Copy the full SHA
    5e1eb7b View commit details
    Browse the repository at this point in the history
  3. lvm2: add myself as maintainer

    ajs124 authored and flokli committed Jul 12, 2020
    Copy the full SHA
    33030f1 View commit details
    Browse the repository at this point in the history
  4. lvm2: fetch sources from http instead of git

    Otherwise, we end up in a dependency cycle:
    
    systemd -> cryptsetup -> lvm -> fetchgit -> git -> openssh -> libfido2 -> hidapi -> libusb -> udev=systemd
    flokli committed Jul 12, 2020
    Copy the full SHA
    fbe7027 View commit details
    Browse the repository at this point in the history
  5. lvm2: 2.03.01 -> 2.03.09

    ajs124 authored and flokli committed Jul 12, 2020
    Copy the full SHA
    3ca74a9 View commit details
    Browse the repository at this point in the history
  6. lvm2: make --enable-cmdlib optional

    This seems to be mostly used to simplify LV management tasks from a web
    interface
    (https://www.redhat.com/archives/linux-lvm/2008-September/msg00029.html),
    and is as fat as the `lvm` binary itself
    flokli committed Jul 12, 2020
    Copy the full SHA
    198d1e6 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    df67459 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    d3a991d View commit details
    Browse the repository at this point in the history
  9. lvm2: fix paths to use /run instead of /var/run.

    This shuts up some warnings.
    ajs124 authored and flokli committed Jul 12, 2020
    Copy the full SHA
    e6a6846 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    b812931 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    9f83907 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. nixos/tasks/lvm: add dmeventd and lvmthin support

    Introduce a pkgs.lvm2_dmeventd that contains dmeventd support, and
    enable if services.lvm.dmeventd.enable is true.
    ajs124 authored and flokli committed Jul 14, 2020
    Copy the full SHA
    1a1e723 View commit details
    Browse the repository at this point in the history
  2. systemd_with_lvm2: remove

    This is already handled by the lvm module, which now properly adds the
    lvm systemd generators.
    
    Initially introduced in c0fd887.
    flokli committed Jul 14, 2020
    Copy the full SHA
    e55ef86 View commit details
    Browse the repository at this point in the history
  3. nixos/test/installer: add postBootCommands

    ajs124 authored and flokli committed Jul 14, 2020
    Copy the full SHA
    d056f6e View commit details
    Browse the repository at this point in the history
  4. nixos/tests/installer: lvm: test lvm2-pvscan@ units

    Also, add some sleep statements in between, which seems to at least feel
    like it causes
    
    > WARNING: Device /dev/vda* not initialized in udev database even after waiting 10000000 microseconds.
    
    To occur less frequently.
    
    This eventually still succeeds after some amount of waiting, I suspect
    some racyness in the way lvm's udev-triggered scripts trigger other
    units.
    ajs124 authored and flokli committed Jul 14, 2020
    Copy the full SHA
    53a3436 View commit details
    Browse the repository at this point in the history
  5. lvm2: rename enable_{cmdlib,dmeventd} to enable{Cmdlib,Dmeventd}

    Make this more consistent with how these flags look like in the rest of
    nixpkgs.
    flokli committed Jul 14, 2020
    Copy the full SHA
    12d32ee View commit details
    Browse the repository at this point in the history
  6. lvm2: passthru tests

    flokli committed Jul 14, 2020
    Copy the full SHA
    9583669 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #93024 from flokli/lvm-fixes

    lvm: cleanups
    flokli committed Jul 14, 2020
    Copy the full SHA
    a224b6e View commit details
    Browse the repository at this point in the history