Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] networkmanager: 1.22.10 -> 1.22.14 #93115

Merged
merged 1 commit into from Jul 18, 2020
Merged

[20.03] networkmanager: 1.22.10 -> 1.22.14 #93115

merged 1 commit into from Jul 18, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 14, 2020 •
edited

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.22.14/NEWS

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace changed the title [20.03] 1.22.10 -> 1.22.14 [20.03] networkmanager: 1.22.10 -> 1.22.14 Jul 14, 2020
@ofborg ofborg bot requested review from domenkozar, obadz and Phreedom July 14, 2020 13:52
@worldofpeace worldofpeace requested a review from a team July 15, 2020 16:20
@jtojnar
Copy link
Contributor

jtojnar commented Jul 16, 2020

Same concern as in #87286 about firewalld-zone.

@worldofpeace worldofpeace merged commit 02d1989 into NixOS:release-20.03 Jul 18, 2020
@worldofpeace worldofpeace deleted the nm-20.03-update branch July 18, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@obadz obadz Awaiting requested review from obadz

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar