Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcollectd: init at 0.11.99.0 #93118

Merged
merged 1 commit into from Dec 30, 2020
Merged

kcollectd: init at 0.11.99.0 #93118

merged 1 commit into from Dec 30, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/misc/kcollectd/default.nix Show resolved Hide resolved
pkgs/tools/misc/kcollectd/default.nix Show resolved Hide resolved
};

strictDeps = true;
nativeBuildInputs = [ cmake shared_mime_info ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such attribute shared_mime_info, that's why the ci error.

@doronbehar
Copy link
Contributor

@symphorien Your PR should have eventually 1 commit:

<package-name>: init at <version>

@symphorien
Copy link
Member Author

@GrahamcOfBorg build kcollectd

@davidak
Copy link
Member

davidak commented Jul 14, 2020

I built it locally and tried to start it, but get this error.
Screenshot from 2020-07-14 18-12-29
Is that expected? How is this package useful?

@doronbehar
Copy link
Contributor

Is that expected? How is this package useful?

Seems normal to me, if you are not running collectd.

@symphorien
Copy link
Member Author

You have to specify --basedir /path/to/collectd/rrd/files

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93118 run on x86_64-linux 1

1 package built:
  • kcollectd

Co-authored-by: davidak <davidak@users.noreply.github.com>
@doronbehar doronbehar merged commit ab6c5e5 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants