Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: da3aea291da2
Choose a base ref
...
head repository: NixOS/nix
compare: 298ff6af8f38
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jul 13, 2020

  1. Fix gitlab-fetcher to obtain tags and branches

    Until now, the `gitlab`-fetcher determined the source's rev by checking
    the latest commit of the given `ref` using the
    `/repository/branches`-API.
    
    This breaks however when trying to fetch a gitlab-repo by its tag:
    
    ```
    $ nix repl
    nix-repl> builtins.fetchTree gitlab:Ma27/nvim.nix/0.2.0
    error: --- Error ------------------------------------------------------------------------------------- nix
    unable to download 'https://gitlab.com/api/v4/projects/Ma27%2Fnvim.nix/repository/branches/0.2.0': HTTP error 404 ('')
    ```
    
    When using the `/commits?ref_name`-endpoint[1] you can pass any kind of
    valid ref to the `gitlab`-fetcher.
    
    Please note that this fetches the only first 20 commits on a ref,
    unfortunately there's currently no endpoint which only retrieves the
    latest commit of any kind of `ref`.
    
    [1] https://docs.gitlab.com/ee/api/commits.html#list-repository-commits
    Ma27 committed Jul 13, 2020
    Copy the full SHA
    cf9f339 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Merge pull request #3809 from Ma27/gitlab-refs

    Fix gitlab-fetcher to obtain tags and branches
    edolstra committed Jul 14, 2020
    Copy the full SHA
    298ff6a View commit details
    Browse the repository at this point in the history