Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmigen.build.res: Ensure all pins are available in a DiffPairs #457

Closed
wants to merge 1 commit into from
Closed

nmigen.build.res: Ensure all pins are available in a DiffPairs #457

wants to merge 1 commit into from

Conversation

jeanthom
Copy link
Contributor

Fixes #456

@jeanthom
Copy link
Contributor Author

Breaks here:

Traceback (most recent call last):
  File "soc.py", line 108, in <module>
    platform.build(soc, do_program=True)
  File "/home/jeanthomas/Documents/nmigen/nmigen/build/plat.py", line 90, in build
    plan = self.prepare(elaboratable, name, **kwargs)
  File "/home/jeanthomas/Documents/nmigen/nmigen/build/plat.py", line 151, in prepare
    for pin, p_port, n_port, attrs, invert in self.iter_differential_pins():
  File "/home/jeanthomas/Documents/nmigen/nmigen/build/res.py", line 182, in iter_differential_pins
    yield pin, port.p, port.n, attrs, res.ios[0].invert
  File "/home/jeanthomas/Documents/nmigen/nmigen/hdl/rec.py", line 149, in __getattr__
    return self[name]
  File "/home/jeanthomas/Documents/nmigen/nmigen/hdl/rec.py", line 160, in __getitem__
    raise AttributeError("{} does not have a field '{}'. Did you mean one of: {}?"
AttributeError: Record 'ddr3_0__clk' does not have a field 'n'. Did you mean one of: p?

whitequark added a commit that referenced this pull request Jul 31, 2020
@whitequark
build,vendor: never carry around parts of differential signals.
83e5aa7 
When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
@whitequark whitequark mentioned this pull request Jul 31, 2020
Merged
whitequark added a commit that referenced this pull request Jul 31, 2020
@whitequark
build,vendor: never carry around parts of differential signals.
de9c1a1 
When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
@jeanthom jeanthom closed this Jul 31, 2020
whitequark added a commit that referenced this pull request Jul 31, 2020
@whitequark
build,vendor: never carry around parts of differential signals.
ba3729e 
When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
whitequark added a commit that referenced this pull request Jul 31, 2020
@whitequark
build,vendor: never carry around parts of differential signals.
d964ba9 
When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative side of diff pair is exposed on ECP5
1 participant
@jeanthom