Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moinmoin: Fix usage of different root #94259

Closed
wants to merge 1 commit into from
Closed

moinmoin: Fix usage of different root #94259

wants to merge 1 commit into from

Conversation

dashmoho
Copy link

Motivation for this change

Option services.moinmoin.wikis..webLocation allows to set different location. But it doesn't really work without this patch - url is interpreted as part of wiki. Side effect is that it cannot find statics, like css.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

maybe this is unrelated. but the moinmoin test fails for me with this:

machine # [   33.118880] gunicorn[917]: ImportError: No module named zope.interface
machine # [   33.122139] gunicorn[917]: [2020-09-10 19:14:08 +0000] [917] [INFO] Worker exiting (pid: 917)
machine # [   33.125676] gunicorn[920]: [2020-09-10 19:14:08 +0000] [920] [INFO] Booting worker with pid: 920
machine # [   33.132851] gunicorn[920]: [2020-09-10 19:14:08 +0000] [920] [ERROR] Exception in worker process
machine # [   33.134865] gunicorn[920]: Traceback (most recent call last):
machine # [   33.138355] gunicorn[920]:   File "/nix/store/9s229sz7yfkf2lc7xgzsc9p0k7vhycnk-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/arbiter.py", line 586, in spawn_worker
machine # [   33.144295] gunicorn[920]:     worker.init_process()
machine # [   33.146342] gunicorn[920]:   File "/nix/store/9s229sz7yfkf2lc7xgzsc9p0k7vhycnk-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 196, in init_process
machine # [   33.153342] gunicorn[920]:     self.patch()
machine # [   33.154587] gunicorn[920]:   File "/nix/store/9s229sz7yfkf2lc7xgzsc9p0k7vhycnk-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 65, in patch
machine # [   33.160320] gunicorn[920]:     monkey.patch_all(subprocess=True)
machine # [   33.163336] gunicorn[920]:   File "/nix/store/m2glggrq45ba5485hzvvzgszxi19nizw-python-2.7.18-env/lib/python2.7/site-packages/gevent/monkey.py", line 1160, in patch_all
machine # [   33.169330] gunicorn[920]:     from gevent import events
machine # [   33.173026] gunicorn[920]:   File "/nix/store/m2glggrq45ba5485hzvvzgszxi19nizw-python-2.7.18-env/lib/python2.7/site-packages/gevent/events.py", line 67, in <module>
machine # [   33.178330] gunicorn[920]:     from zope.interface import Interface
machine # [   33.181422] gunicorn[920]: ImportError: No module named zope.interface
(0.17 seconds)
error:
Traceback (most recent call last):
  File "/nix/store/kcy6z1kbf4qd6jvv6y9c9g43sdsxy466-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 898, in run_tests
    exec(tests, globals())
  File "<string>", line 1, in <module>
  File "<string>", line 7, in <module>
AssertionError
cleaning up
killing machine (pid 9)
(0.00 seconds)
builder for '/nix/store/ksja5pr4n4b8a25j3j2d80660yas1zfz-vm-test-run-moinmoin.drv' failed with exit code 1
error: build of '/nix/store/ksja5pr4n4b8a25j3j2d80660yas1zfz-vm-test-run-moinmoin.drv' failed

@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
@dali99
Copy link
Member

dali99 commented Nov 30, 2023

moinmoin was removed in #153012 for being broken and python2

@dali99 dali99 closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dashmoho @Lassulus @dali99