ryujinx: init at 1.0.5160 #94329
Merged
ryujinx: init at 1.0.5160 #94329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jul 31, 2020
IvarWithoutBones
force-pushed
the
ryujinx
branch
from
7858c4d
to
66b39d6
Compare
jonringer
reviewed
Aug 9, 2020
| runHook postBuild | ||
| ''; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
getting wrapped 3 times
Suggested change
| installPhase = '' | |
| dontWrapGApps = true; | |
| installPhase = '' |
IvarWithoutBones
force-pushed
the
ryujinx
branch
from
66b39d6
to
cd73c6a
Compare
|
With all of those suggestions added, the app fails to open the file picker: Not using |
IvarWithoutBones
force-pushed
the
ryujinx
branch
from
cd73c6a
to
872ffac
Compare
oh, may need to have |
jonringer
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 94329 1
18 packages marked as broken and skipped:
- linuxPackages_hardkernel_4_14.prl-tools - linuxPackages_hardkernel_4_14.r8125 - linuxPackages_hardkernel_4_14.r8168 - linuxPackages_hardkernel_4_14.rtl8814au - linuxPackages_hardkernel_4_14.rtl8821au - linuxPackages_hardkernel_4_14.rtl8821ce - linuxPackages_hardkernel_4_14.rtl88x2bu - linuxPackages_hardkernel_4_14.rtl88xxau-aircrack - linuxPackages_hardkernel_4_14.rtlwifi_new - php72Packages.phpmd - php74Extensions.zmq - python27Packages.habanero - python27Packages.handout - python27Packages.hass-nabucasa - python37Packages.notify - python37Packages.pyblock - python38Packages.notify - qes1 package built:
- ryujinx
|
Thanks to both of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds Ryujinx, a Nintendo Switch emulator written in C#.
This is my first time doing any dotnet packaging, so I've mainly based this off of osu-lazer.
The update script for that uses some checks to see if it already has the latest dependencies (for the
deps.nix), however i could not get that to work here as there are no stable builds.Upstream does not have stable releases, however dotnet fails when using the regular
unstable-${date}version convention for git revs. The current versioning is based off of the official appveyor builds.Ryujinx normally tries to write logs next to the executable, so to the nix store. I've added a patch which just puts those in the directory you're launching it from.
Edit: Patch now writes logs to
~/.config/Ryujinx/Logs/on Linux, and the appropriate directory on other platforms as well.Closes: #85684
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)